[Windows] codelite is moving to wxwidgets 2.9.2

[frank_frl]

Hi Eran,

I installed MinGW that comes with CL, rebuild wxWidgets, did a clean CL checkout and tried to build CL with old CL 4984 but with the same 'AttachConsole' error.
Then I used CL 5006 to build and that finally worked. So I could build CL 5012 now, but it has the same bug as 5006, the key '<>|' (the key right beside the left SHIFT key on my German keyboard) is dead.

Regards

Frank

[jfouche]

The same for me :

D:/_perso/projects/codelite/CodeLite/winprocess_impl.cpp:62: error: 'AttachConsole' was not declared in this scope

edit

D:\_perso\projects\lib\wxWidgets-2.9.2\build\msw>gcc --version
gcc (TDM-2 mingw32) 4.4.1
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I probably do not use the same gcc as yours...

[frank_frl]

Hi Jérémie,

what version of CL you used to build. Install this one and try it again:
http://codelite.org/forum/viewtopic.php ... 1410#p6469

Regards

Frank

[eranif]

So I could build CL 5012 now

At least we are getting somewhere now

but it has the same bug as 5006, the key '<>|' (the key right beside the left SHIFT key on my German keyboard) is dead.

I dont have german keyboard - so I cant help you there.

Can you try and debug it? (I would start by placing a breakpoint at LEditor::OnCharAdded method and see how it goes from there
If the breakpoint does not hit, try placing one at Leditor::OnKeyDown

Eran

[frank_frl]

At least we are getting somewhere now

But that means , that CL won't build with gcc 4.5x

Can you try and debug it? (I would start by placing a breakpoint at LEditor::OnCharAdded method and see how it goes from there
If the breakpoint does not hit, try placing one at Leditor::OnKeyDown

OnCharAdded is never called for that key and OnKeyDown gives an event.m_keyCode = 0, event.m_uniChar = 226, but they should both be 226.

No problems with that key in any other software and I never had this problem with previous versions of CL.

Unfortunately I don't have the time at the moment to do more investigation so I'm going to stick to CL 4984

Regards

Frank

[eranif]

But that means , that CL won't build with gcc 4.5x

I don't see the urge to upgrade to 4.5.x atm, I will probably address this issue when I will attempt to compile codeilte with 4.5 or later (or when I will get from my summer vacation and will have some free time)

OnCharAdded is never called for that key and OnKeyDown gives an event.m_keyCode = 0, event.m_uniChar = 226, but they should both be 226.

The first error seems like a problem that is caused due to the second (wrong values in wxKeyEvent)
since OnKeyDown is called directly from wxWidgets - I would say that this is a bug in wxWidgets and should be reported (I know that you said that you dont have time for that, but I would check the wxStyledTextCtrl sample (named: samples/stc) in 292 and see how it behaves)

Eran

[frank_frl]

Hi Eran,

since OnKeyDown is called directly from wxWidgets - I would say that this is a bug in wxWidgets and should be reported (I know that you said that you dont have time for that, but I would check the wxStyledTextCtrl sample (named: samples/stc) in 292 and see how it behaves)

Bad news!
The stc sample has the same problem, so I guess you are right, this is a wxWidgets bug, but that means also that the new CL versions are useless at least for people with a German keyboard
It's hard to write C++ code without <>|

Regards

Frank

[eranif]

Can you please paste here the backtrace of OnKeyDown? I would like to see whether I can fix this locally in the copy of wxwidgets that I ship with codelite or maybe hack it in someway

The backtrace is needed so I could see where to start looking inside wxwidgets sources
Eran

[eranif]

Hi Frank,

Can you please place a breakpoint here:

wxscintilla.cpp:3232

There is an interesing comment on this method that might explain your problem:

Code: Select all

    // On (some?) non-US keyboards the AltGr key is required to enter some
    // common characters.  It comes to us as both Alt and Ctrl down so we need
    // to let the char through in that case, otherwise if only ctrl or only

This is the place that decides whether or not to send the 'OnCharAdded' event
In addition, I started a thread on the wxUsers mailing list and got VZ attention

Eran

[eranif]

Hi Frank,

I managed to debug and fix this ("<>|" not working for 2.9.x) using Microsoft's on-screen keyboard with German keyboard enabled
Can you please build latest codelite from SVN and give it a try?

I would really appreciate your confirmation on the fix

Eran